From ad6d38809a27abe460c8323d70bbbfa175cb7b26 Mon Sep 17 00:00:00 2001 From: kshivang Date: Sun, 13 Oct 2019 14:05:38 +0530 Subject: [PATCH] Bug fixed ExoPlayerAnalyticalListenerImp suppressed for now since it was causing fatal crashing on some build --- README.md | 2 +- .../java/ai/rever/goonj/analytics/ItemActionCallbackImp.kt | 2 ++ goonj/src/main/java/ai/rever/goonj/player/LocalAudioPlayer.kt | 4 ++-- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index 80123a8..99c337a 100644 --- a/README.md +++ b/README.md @@ -19,7 +19,7 @@ allprojects { Add following in build.gradle (App level): ``` dependencies { - implementation 'com.github.rever-ai:goonj:0.4.3' + implementation 'com.github.rever-ai:goonj:0.5' // Exo Player implementation 'com.google.android.exoplayer:exoplayer-core:2.10.3' implementation 'com.google.android.exoplayer:exoplayer-ui:2.10.3' diff --git a/goonj/src/main/java/ai/rever/goonj/analytics/ItemActionCallbackImp.kt b/goonj/src/main/java/ai/rever/goonj/analytics/ItemActionCallbackImp.kt index 30ae1cd..d57041b 100644 --- a/goonj/src/main/java/ai/rever/goonj/analytics/ItemActionCallbackImp.kt +++ b/goonj/src/main/java/ai/rever/goonj/analytics/ItemActionCallbackImp.kt @@ -7,6 +7,8 @@ import androidx.mediarouter.media.RemotePlaybackClient open class ItemActionCallbackImp(var operation: String, var onSuccess: ((String?, MediaItemStatus?) -> Unit)? = null) : RemotePlaybackClient.ItemActionCallback() { + + override fun onResult( data: Bundle?, sessionId: String?, diff --git a/goonj/src/main/java/ai/rever/goonj/player/LocalAudioPlayer.kt b/goonj/src/main/java/ai/rever/goonj/player/LocalAudioPlayer.kt index e721da8..d638a1d 100644 --- a/goonj/src/main/java/ai/rever/goonj/player/LocalAudioPlayer.kt +++ b/goonj/src/main/java/ai/rever/goonj/player/LocalAudioPlayer.kt @@ -163,7 +163,7 @@ internal class LocalAudioPlayer: AudioPlayer { } private fun addListeners(){ - player?.addAnalyticsListener(ExoPlayerAnalyticsListenerImp) +// player?.addAnalyticsListener(ExoPlayerAnalyticsListenerImp) player?.addListener(eventListener) } @@ -181,7 +181,7 @@ internal class LocalAudioPlayer: AudioPlayer { GoonjSessionMediaConnector.release() - player?.removeAnalyticsListener(ExoPlayerAnalyticsListenerImp) +// player?.removeAnalyticsListener(ExoPlayerAnalyticsListenerImp) player?.removeListener(eventListener) player?.release() player = null