Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra dependency for deoplete-solargraph.py #6

Open
uplus opened this issue Apr 24, 2018 · 2 comments
Open

Remove extra dependency for deoplete-solargraph.py #6

uplus opened this issue Apr 24, 2018 · 2 comments

Comments

@uplus
Copy link
Owner

uplus commented Apr 24, 2018

I separated deoplete-solargraph and solargraph-utils.py from the viewpoint of maintainability and modularity.
This made development very easy, but for users it would be troublesome to add more packages to manage.

But, if solargraph-utils.py is merged, dependencies on solargraph and python neovim-client remain.
So, I don't feel much merit in merging deoplete-solargraph.py.

The best solution I think is to make solargraph-utils.py manageable with vim's plugin manager.

@iovis
Copy link

iovis commented Apr 25, 2018

But solargraph is used by other editors for autocompletion and neovim client is used by other plugins in neovim. deoplete-solargraph.py is only used by this plugin, that's why I find it troublesome. But I agree it's probably easier to maintain separately.

@halftan
Copy link

halftan commented Apr 26, 2018

No, it doesn't make it easier to maintain this plugin and it's added extra effort to develop/bugfix this plugin since I need to open up two workspaces and switching between each other frequently. The two projects are coupling so close to each other and I highly doubt that there will be another repo depending on solargraph-utils.py, thus there's no benefit on separating these two repos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants