feat(): refactor, add XIRSA composition, optional path for xservice gitops locations #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haarchri
force-pushed
the
feature/irsa
branch
3 times, most recently
from
f182e45
to
158f01a
Compare
Signed-off-by: Christopher Haar <[email protected]>
haarchri
force-pushed
the
feature/irsa
branch
from
4885a76
to
b70fdab
Compare
|
/test-examples=".up/examples/gcp/spoke-cluster.yaml" |
|
/test-examples=".up/examples/azure/spoke-cluster.yaml" |
|
/test-examples=".up/examples/aws/spoke-cluster.yaml" |
ytsarev
requested changes
Sep 15, 2023
There was a problem hiding this comment.
Put the whole stuff through the validation webhook:
find . -iname '*.yaml' |grep -v crossplane.yaml | xargs -n1 kubectl apply -f 2>&1 | grep Invalid
The Composition "xnetworks.azure.caas.upbound.io" is invalid: spec.resources[2].patches[3].patchSets[3].patches[0].toFieldPath: Invalid value: "spec.forProvider.location": field 'location' is not valid according to the schema
* spec.resources[1].patches[1].patchSets[1].patches[0].toFieldPath: Invalid value: "spec.deletionPolicy": field 'deletionPolicy' is not valid according to the schema
* spec.resources[2].patches[1].patchSets[1].patches[0].toFieldPath: Invalid value: "spec.deletionPolicy": field 'deletionPolicy' is not valid according to the schema
* spec.resources[0].patches[0].patchSets[0].patches[3].fromFieldPath: Invalid value: "spec.parameters.deletionPolicy": field 'parameters' is not valid according to the schema
* spec.resources[1].patches[0].patchSets[0].patches[3].fromFieldPath: Invalid value: "spec.parameters.deletionPolicy": field 'parameters' is not valid according to the schema
* spec.resources[0].patches[0].patchSets[0].patches[3].fromFieldPath: Invalid value: "spec.parameters.deletionPolicy": field 'parameters' is not valid according to the schema
* spec.resources[1].patches[0].patchSets[0].patches[3].fromFieldPath: Invalid value: "spec.parameters.deletionPolicy": field 'parameters' is not valid according to the schema
* spec.resources[2].patches[0].patchSets[0].patches[3].fromFieldPath: Invalid value: "spec.parameters.deletionPolicy": field 'parameters' is not valid according to the schema
The Composition "xclusters.azure.caas.upbound.io" is invalid: spec.resources[2].patches[0].toFieldPath: Invalid value: "spec.parameters.deletionPolicy": field 'parameters' is not valid according to the schema
* spec.resources[0].patches[0].patchSets[0].patches[3].fromFieldPath: Invalid value: "spec.parameters.deletionPolicy": field 'parameters' is not valid according to the schema
* spec.resources[1].patches[0].patchSets[0].patches[3].fromFieldPath: Invalid value: "spec.parameters.deletionPolicy": field 'parameters' is not valid according to the schema
* spec.resources[0].patches[0].patchSets[0].patches[3].fromFieldPath: Invalid value: "spec.parameters.deletionPolicy": field 'parameters' is not valid according to the schema
* spec.resources[1].patches[0].patchSets[0].patches[3].fromFieldPath: Invalid value: "spec.parameters.deletionPolicy": field 'parameters' is not valid according to the schema
* spec.resources[2].patches[0].patchSets[0].patches[3].fromFieldPath: Invalid value: "spec.parameters.deletionPolicy": field 'parameters' is not valid according to the schema
The Composition "xclusters.gcp.caas.upbound.io" is invalid: spec.resources[2].patches[0].toFieldPath: Invalid value: "spec.parameters.deletionPolicy": field 'parameters' is not valid according to the schema
* spec.resources[0].patches[0].patchSets[0].patches[3].fromFieldPath: Invalid value: "spec.parameters.deletionPolicy": field 'parameters' is not valid according to the schema
* spec.resources[1].patches[0].patchSets[0].patches[3].fromFieldPath: Invalid value: "spec.parameters.deletionPolicy": field 'parameters' is not valid according to the schema
* spec.resources[0].patches[0].patchSets[0].patches[3].fromFieldPath: Invalid value: "spec.parameters.deletionPolicy": field 'parameters' is not valid according to the schema
* spec.resources[1].patches[0].patchSets[0].patches[3].fromFieldPath: Invalid value: "spec.parameters.deletionPolicy": field 'parameters' is not valid according to the schema
* spec.resources[2].patches[0].patchSets[0].patches[3].fromFieldPath: Invalid value: "spec.parameters.deletionPolicy": field 'parameters' is not valid according to the schema
The Composition "xclusters.aws.caas.upbound.io" is invalid: spec.resources[2].patches[0].toFieldPath: Invalid value: "spec.parameters.deletionPolicy": field 'parameters' is not valid according to the schema
It looks like spec.parameters.deletionPolicy should be changed spec.deletionPolicy in multiple places
Signed-off-by: Christopher Haar <[email protected]>
Signed-off-by: Christopher Haar <[email protected]>
|
|
|
/test-examples=".up/examples/aws/spoke-cluster.yaml" |
|
/test-examples=".up/examples/azure/spoke-cluster.yaml" |
|
/test-examples=".up/examples/gcp/spoke-cluster.yaml" |
ytsarev
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Refactor:
sizetoinstanceTypeAdditions:
Fixes #
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR, as appropriate.How has this code been tested