Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix grammar in Fragment props JSDoc comment #1437

Merged
merged 1 commit into from
Nov 27, 2024
Merged

chore: fix grammar in Fragment props JSDoc comment #1437

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/radix-vue/src/Primitive/Primitive.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ export interface PrimitiveProps {
*/
asChild?: boolean
/**
* The element or component this component should render as. Can be overwrite by `asChild`
* The element or component this component should render as. Can be overwritten by `asChild`.
* @defaultValue "div"
*/
as?: AsTag | Component
Expand Down
4 changes: 2 additions & 2 deletions packages/radix-vue/src/Primitive/Slot.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,13 @@ export const Slot = defineComponent({

const firstNonCommentChildren = childrens[firstNonCommentChildrenIndex]

// remove props ref from being inferred
// Remove props ref from being inferred
delete firstNonCommentChildren.props?.ref

const mergedProps = firstNonCommentChildren.props
? mergeProps(attrs, firstNonCommentChildren.props)
: attrs
// remove class to prevent duplicated
// Remove class to prevent duplicated
if (attrs.class && firstNonCommentChildren.props?.class)
delete firstNonCommentChildren.props.class
const cloned = cloneVNode(firstNonCommentChildren, mergedProps)
Expand Down