Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better handling of async event creation #15243

Open
julien51 opened this issue Dec 4, 2024 · 1 comment · May be fixed by #15249
Open

Better handling of async event creation #15243

julien51 opened this issue Dec 4, 2024 · 1 comment · May be fixed by #15249
Assignees
@0xTxbi
Labels
🚨 High Priority

Comments

@julien51
Copy link
Member

julien51 commented Dec 4, 2024

We currently rely on the user being able to "witness" the lock deployment before creating an event. This is pretty fragile because the user's connection may break, or they may close the tab... etc, leading to an issue where the event is not created even though the lock has been deployed.
We need to handle this better!
@0xTxbi
Copy link
Member

0xTxbi commented Dec 4, 2024

got it!

@0xTxbi 0xTxbi linked a pull request Dec 6, 2024 that will close this issue
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0xTxbi 0xTxbi

Labels
🚨 High Priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feature(unlock-app): Decouple event creation from user connection state unlock-protocol/unlock
2 participants
@julien51 @0xTxbi