feat(contracts): deploying the allow-list hook on all networks #15123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien51
commented
Nov 22, 2024
| `FAIL: Verification failed for contract at ${address} with args : ${deployArgs.toString()}` | ||
| ) | ||
| console.log(error) | ||
| let tries = 0 |
There was a problem hiding this comment.
I went for 5 tries approach so it's not too verbose and still exits after it failed too many times.
packages/networks/src/networks/arbitrum.tsThe setup is successful :
Some additonal warnings :
packages/networks/src/networks/avalanche.tsThe setup is successful :
Some additonal warnings :
packages/networks/src/networks/base-sepolia.tsThe setup is successful :
Some additonal warnings :
packages/networks/src/networks/base.tsThe setup is successful :
We have found the following errors :
Some additonal warnings :
packages/networks/src/networks/bsc.tsThe setup is successful :
Some additonal warnings :
packages/networks/src/networks/celo.tsThe setup is successful :
Some additonal warnings :
packages/networks/src/networks/gnosis.tsThe setup is successful :
Some additonal warnings :
packages/networks/src/networks/linea.tsThe setup is successful :
Some additonal warnings :
packages/networks/src/networks/mainnet.tsThe setup is successful :
We have found the following errors :
Some additonal warnings :
packages/networks/src/networks/optimism.tsThe setup is successful :
Some additonal warnings :
packages/networks/src/networks/scroll.tsThe setup is successful :
Some additonal warnings :
packages/networks/src/networks/sepolia.tsThe setup is successful :
Some additonal warnings :
packages/networks/src/networks/zkevm.tsThe setup is successful :
Some additonal warnings :
|
|
Error: missing revert data (action="call", data=null, reason=null, transaction={ "data": "0xcd93b532", "to": "0x259813B665C8f6074391028ef782e27B65840d89" }, invocation=null, revert=null, code=CALL_EXCEPTION, version=6.13.4) |
packages/networks/src/networks/arbitrum.tsThe setup is successful :
Some additonal warnings :
packages/networks/src/networks/avalanche.tsThe setup is successful :
Some additonal warnings :
packages/networks/src/networks/base-sepolia.tsThe setup is successful :
Some additonal warnings :
packages/networks/src/networks/base.tsThe setup is successful :
We have found the following errors :
Some additonal warnings :
packages/networks/src/networks/bsc.tsThe setup is successful :
Some additonal warnings :
packages/networks/src/networks/celo.tsThe setup is successful :
Some additonal warnings :
packages/networks/src/networks/gnosis.tsThe setup is successful :
Some additonal warnings :
packages/networks/src/networks/linea.tsThe setup is successful :
Some additonal warnings :
packages/networks/src/networks/mainnet.tsThe setup is successful :
We have found the following errors :
Some additonal warnings :
packages/networks/src/networks/optimism.tsThe setup is successful :
Some additonal warnings :
packages/networks/src/networks/scroll.tsThe setup is successful :
Some additonal warnings :
packages/networks/src/networks/sepolia.tsThe setup is successful :
Some additonal warnings :
packages/networks/src/networks/zkevm.tsThe setup is successful :
Some additonal warnings :
|
|
I am cmpletely unable to send tx to Polygon which is quite annoying :/ |
clemsos
approved these changes
Nov 25, 2024
| @@ -62,7 +62,7 @@ Object.keys(networks).forEach((key) => { | |||
| hardhatNetworks[key] = { | |||
| chainId: networks[key].id, | |||
| name: networks[key].name, | |||
| url: networks[key].provider, | |||
| url: networks[key].publicProvider, | |||
There was a problem hiding this comment.
we are not distributing this package though
weird. Does that work directly from cli (without |
Co-authored-by: Clément Renaud <[email protected]>
packages/networks/src/networks/arbitrum.tsThe setup is successful :
Some additonal warnings :
packages/networks/src/networks/avalanche.tsThe setup is successful :
Some additonal warnings :
packages/networks/src/networks/base-sepolia.tsThe setup is successful :
Some additonal warnings :
packages/networks/src/networks/base.tsThe setup is successful :
We have found the following errors :
Some additonal warnings :
packages/networks/src/networks/bsc.tsThe setup is successful :
Some additonal warnings :
packages/networks/src/networks/celo.tsThe setup is successful :
Some additonal warnings :
packages/networks/src/networks/gnosis.tsThe setup is successful :
Some additonal warnings :
packages/networks/src/networks/linea.tsThe setup is successful :
Some additonal warnings :
packages/networks/src/networks/mainnet.tsThe setup is successful :
We have found the following errors :
Some additonal warnings :
packages/networks/src/networks/optimism.tsThe setup is successful :
Some additonal warnings :
packages/networks/src/networks/scroll.tsThe setup is successful :
Some additonal warnings :
packages/networks/src/networks/sepolia.tsThe setup is successful :
Some additonal warnings :
packages/networks/src/networks/zkevm.tsThe setup is successful :
Some additonal warnings :
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This also includes a few script changes.
Issues
Fixes #
Refs #
Checklist:
Release Note Draft Snippet