-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] LinearRegression get_estimator method's required arguments appear to do nothing #2494
Comments
Update: I am now seeing that it is due to this if statements. It's currently unclear to me what makes a model object subclass I still feel that |
Hi @a097123, Darts relies on sklearn implementation for all the regression models. This In your code snippet, you implicitly use the sklearn's If you look at We could move the sanity check one level in the method to avoid the unexpected behavior you reported. Changing the logging message from Note: Darts |
@madtoinou Thank you for the detailed response! This helps me understand what the class is doing much better. Also appreciate the suggestion of I personally think that warning is better here but I am new to the lib and you might know better than me what a darts user might expect there. This might just be a weird edge case only a noob would hit before taking a more conventional approach. |
Describe the bug
No matter what is passed into the get_estimator method of the LinearRegression class the same model object is returned.
To Reproduce
Expected behavior
My assumption was that a Darts model would build 1 underlying model per future time period, i.e. "direct forecasting".
get_regressor
takes 2 arguments:No matter the arguments passed in the method will...
Both are unexpected to me.
System (please complete the following information):
Additional context
New to darts.
The text was updated successfully, but these errors were encountered: