Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WARNING about dependecies which were removed with darts 0.25.0 #1972

Closed
MichalRIcar opened this issue Aug 29, 2023 · 3 comments · Fixed by #1986
Closed

WARNING about dependecies which were removed with darts 0.25.0 #1972

MichalRIcar opened this issue Aug 29, 2023 · 3 comments · Fixed by #1986
Labels
devops CI/CD, packaging, code maintenance, ... question Further information is requested

Comments

@MichalRIcar
Copy link

Hello,

I've just installed
Python 3.11.4
darts 0.25.0

on Windows 11 via pip install darts

everything works OK, however, Python is printing following WARNINGs

WARNING:darts.models.utils:The Prophet module could not be imported. To enable Prophet support in Darts, follow the detailed instructions in the installation guide: https://github.com/unit8co/darts/blob/master/INSTALL.md

WARNING:darts.models.utils:The CatBoost module could not be imported. To enable CatBoost support in Darts, follow the detailed instructions in the installation guide: https://github.com/unit8co/darts/blob/master/INSTALL.md

When reading Your installation instructions:
Enabling Optional Dependencies
By default, as of 0.25.0, darts does not have Prophet, CatBoost, and LightGBM as dependencies anymore...

I am wondering if the WARNINGs above are appropriate under the last change?

Best,
Michal

@MichalRIcar MichalRIcar added bug Something isn't working triage Issue waiting for triaging labels Aug 29, 2023
@MichalRIcar MichalRIcar changed the title [BUG] WARNING about dependecies which were removed with darts 0.25.0 Aug 29, 2023
@dennisbader
Copy link
Collaborator

Hi @MichalRIcar, do you mean that we should not raise these warnings when importing somethiing from Darts?

The model wrappers are still supported in Darts after installing the dependencies. So I think we will continue to log the warnings for now.
You can also install pip install u8darts[all], or conda install -c conda-forge u8darts-all which will install all the dependencies and remove this warning.

@madtoinou madtoinou added question Further information is requested devops CI/CD, packaging, code maintenance, ... and removed bug Something isn't working triage Issue waiting for triaging labels Aug 30, 2023
@MichalRIcar
Copy link
Author

MichalRIcar commented Sep 4, 2023

Hello @dennisbader,

I am referring to the fact that default installation design is to not install Prophet, CatBoost, LightGBM.
"By default, as of 0.25.0, darts does not have Prophet, CatBoost, and LightGBM as dependencies anymore..."

When user with the default installation run any operation from darts lib (not connected with the 3 packages) then he/she sees those 3 WARNINGs from WARNING:darts.models.utils all the time and these are referring just to the new design of >= v.0.25.0.

I was thinking, when user explicitly asks for these opt packages (call them), it would be nice to rise an error describing/instructing the user to install opt packages rather than rising warnings all the time to users who have no need of it.

I know I can suppress it, but in general I believe that warning should be a real warning rather than a note referring to some options of the lib.

@dennisbader
Copy link
Collaborator

Hi @MichalRIcar, agreed. #1986 removes the warnings and raises an error when trying to create a model with missing dependency

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops CI/CD, packaging, code maintenance, ... question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants