Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ack with no following token for rtcp-fb #189

Open
ekr opened this issue Oct 8, 2014 · 1 comment
Open

Allow ack with no following token for rtcp-fb #189

ekr opened this issue Oct 8, 2014 · 1 comment

Comments

@ekr
Copy link

ekr commented Oct 8, 2014

switch (rtcpfb->feedback_type) {
  case SDP_RTCP_FB_ACK:
    type = SdpRtcpFbAttributeList::kAck;
    switch (rtcpfb->param.ack) {
      // TODO: sipcc doesn't seem to support ack with no following token
      case SDP_RTCP_FB_ACK_RPSI:
        parameter = SdpRtcpFbAttributeList::rpsi;
        break;
      case SDP_RTCP_FB_ACK_APP:
        parameter = SdpRtcpFbAttributeList::app;
        break;
      default:
        // Unknown type, ignore.
        continue;
    }
@docfaraday
Copy link

This is not a regression (we've never supported this), so I'm not inclined to make this a blocker on shipping.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants