Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEEDBACK] Limits of Digit Size Options #960

Open
sffc opened this issue Nov 25, 2024 · 2 comments
Open

[FEEDBACK] Limits of Digit Size Options #960

sffc opened this issue Nov 25, 2024 · 2 comments
Labels
Preview-Feedback Feedback gathered during the technical preview

Comments

@sffc
Copy link
Member

sffc commented Nov 25, 2024

The Digit Size Options in registry.md say they use the following EBNF:

digit-size-option = "0" / (("1"-"9") [DIGIT])

This appears to accept 0, 1, 2, ..., 9, 10, 11, ..., 98, 99.

However, ECMA-402 restricts the range of some of these integers to be less. For example, minimum and maximum significant digits and minimum integer digits are restricted to the range 1-21:

https://tc39.es/ecma402/#sec-setnfdigitoptions

@sffc sffc added the Preview-Feedback Feedback gathered during the technical preview label Nov 25, 2024
@eemeli
Copy link
Collaborator

eemeli commented Nov 25, 2024

Given that the spec also includes

A "digit size option" is an _option_ value that the _function_ interprets
as a small integer value greater than or equal to zero.
Implementations MAY define an upper limit on the _resolved value_
of a digit size option option consistent with that implementation's practical limits.

it's not clear to me what this feedback is about?

@sffc
Copy link
Member Author

sffc commented Nov 25, 2024

I feel limits on these options should be more strict in general because it is a dereliction of duty for MF2 to allow a message that is supported in one implementation but rejected in another (without using implementation-specific namespaced options), but I'll leave it up to the WG to decide if this text, permitting engines to differ in the limits they impose, is acceptable to MF2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Preview-Feedback Feedback gathered during the technical preview
Projects
None yet
Development

No branches or pull requests

2 participants