CLDR-17399 Fix infinite loops due to removing boxed primitive constructors #3567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctors -JSONObject had recursive calls in put double/int/long -Use Double/Integer/Long.valueOf to call the version of put with Object parameter
macchiati
approved these changes
Mar 13, 2024
|
@mihnita FYI |
|
Sorry, the change was a bit big and I didn't see it. |
|
@mihnita Thank you for improving the code! There's always some risk in a big modernization like this, and modernization is necessary. The problem here wasn't obvious. The fact that we didn't detect it until deployment on the production server (fortunately when it wasn't open for vetting) reveals a weakness in the automated testing, and we're going to study how to improve that. Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-JSONObject had recursive calls in put double/int/long
-Use Double/Integer/Long.valueOf to call the version of put with Object parameter
CLDR-17399
ALLOW_MANY_COMMITS=true