Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLDR-17432 Fix markup bug #3551

Merged
merged 2 commits into from
Mar 4, 2024
Merged

CLDR-17432 Fix markup bug #3551

merged 2 commits into from
Mar 4, 2024

Conversation

macchiati
Copy link
Member

CLDR-17432

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

@macchiati
Copy link
Member Author

Please merge when reviewed and approved, and respond to the recent email with subject "Alpha"

srl295
srl295 reviewed Mar 4, 2024
View reviewed changes
Copy link
Member

@srl295 srl295 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK but also need to fix https://github.com/unicode-org/cldr/pull/3551/files#diff-549880ab02f2fc27e87768d55cd7030b3afb0f5b18db21ef4297c2cddf9c985bL1775

@srl295
Copy link
Member

srl295 commented Mar 4, 2024

OK but also need to fix https://github.com/unicode-org/cldr/pull/3551/files#diff-549880ab02f2fc27e87768d55cd7030b3afb0f5b18db21ef4297c2cddf9c985bL1775

I fixed it with a second commit as a maintainer

@srl295 srl295 merged commit 9db46cc into unicode-org:main Mar 4, 2024
7 checks passed
@macchiati macchiati deleted the CLDR-17432-Fix-markup-bug branch March 5, 2024 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srl295 srl295 srl295 approved these changes

@AEApple AEApple Awaiting requested review from AEApple

@btangmu btangmu Awaiting requested review from btangmu

@DraganBesevic DraganBesevic Awaiting requested review from DraganBesevic

Assignees

@srl295 srl295

@macchiati macchiati

@AEApple AEApple

@btangmu btangmu

@DraganBesevic DraganBesevic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@macchiati @srl295 @AEApple @btangmu @DraganBesevic