CLDR-17418 GenerateLanguageContainment: avoid loops #3535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srl295
requested review from
btangmu,
DraganBesevic,
macchiati and
pedberg-icu
srl295
commented
Feb 27, 2024
macchiati
previously approved these changes
Feb 27, 2024
|
@macchiati quick addition: failing exit status, and final error message. So the loop errors don't get buried. |
srl295
changed the title
|
@macchiati are you OK with my accepting the subtask of your task? |
|
Yes, of course; any fixes for BRS tools get auto-accepted. |
macchiati
approved these changes
Feb 27, 2024
See unicode-org#3535 Update Containment to not stack overflow when there are containment loops. Report the loops (sparingly) to console. See CLDR-15020 (cherry picked from commit d1ae5db)
srl295
force-pushed
the
cldr-15020/cldr-17418/language-containment-loops
branch
from
322c159 to
9721cc1
Compare
|
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Containment to not stack overflow when there are containment loops.
Report the loops (sparingly) to console.
(cherry picked from commit d1ae5db #3249)
CLDR-17418
ALLOW_MANY_COMMITS=true