From 4defbc217711956d3ee64d15367b5325d09fb58b Mon Sep 17 00:00:00 2001 From: "Steven R. Loomis" Date: Fri, 23 Feb 2024 13:06:45 -0600 Subject: [PATCH] CLDR-17388 update known issues - remove additional commented-out or now-passing issues --- .../org/unicode/cldr/unittest/TestAttributeValues.java | 4 ---- .../java/org/unicode/cldr/unittest/TestCLDRFile.java | 6 ------ .../org/unicode/cldr/unittest/TestSupplementalInfo.java | 9 --------- .../java/org/unicode/cldr/unittest/TestTransforms.java | 7 ------- .../java/org/unicode/cldr/unittest/TestValidity.java | 4 ---- 5 files changed, 30 deletions(-) diff --git a/tools/cldr-code/src/test/java/org/unicode/cldr/unittest/TestAttributeValues.java b/tools/cldr-code/src/test/java/org/unicode/cldr/unittest/TestAttributeValues.java index a6462e94d02..a288cafb6b5 100644 --- a/tools/cldr-code/src/test/java/org/unicode/cldr/unittest/TestAttributeValues.java +++ b/tools/cldr-code/src/test/java/org/unicode/cldr/unittest/TestAttributeValues.java @@ -308,10 +308,6 @@ void show(boolean verbose, ImmutableSet retain) { testLog.warnln("Skipping for keyboard3"); } boolean haveProblems = false; - // if (testLog.logKnownIssue("cldrbug 10120", "Don't enable error until - // complete")) { - // testLog.warnln("Counts: " + counter.toString()); - // } else for (ValueStatus valueStatus : ValueStatus.values()) { if (valueStatus == ValueStatus.valid) { continue; diff --git a/tools/cldr-code/src/test/java/org/unicode/cldr/unittest/TestCLDRFile.java b/tools/cldr-code/src/test/java/org/unicode/cldr/unittest/TestCLDRFile.java index c1dfd094bb0..250ec4df791 100644 --- a/tools/cldr-code/src/test/java/org/unicode/cldr/unittest/TestCLDRFile.java +++ b/tools/cldr-code/src/test/java/org/unicode/cldr/unittest/TestCLDRFile.java @@ -795,12 +795,6 @@ public void TestFileIds() { } String likely = likelySubtags.minimize(loc); if (!localesToDirs.containsKey(parent)) { - // if (ldmlDir == LdmlDir.rbnf && source == Source.common && - // parent.equals("en_001") && loc.equals("en_IN") && - // logKnownIssue("cldrbug:10456", "Missing parent - // (en_001) for en_IN in common/rbnf")) { - // continue; - // } errln( "Missing parent (" + parent diff --git a/tools/cldr-code/src/test/java/org/unicode/cldr/unittest/TestSupplementalInfo.java b/tools/cldr-code/src/test/java/org/unicode/cldr/unittest/TestSupplementalInfo.java index e1efa06464d..b24176e90f7 100644 --- a/tools/cldr-code/src/test/java/org/unicode/cldr/unittest/TestSupplementalInfo.java +++ b/tools/cldr-code/src/test/java/org/unicode/cldr/unittest/TestSupplementalInfo.java @@ -947,9 +947,7 @@ public void TestTimeData() { + oldSchool + " in allowed: " + preferredAndAllowedHour.allowed; - // if (!logKnownIssue("cldrbug:11448", message)) { errln(message); - // } } break; } @@ -1876,13 +1874,6 @@ public void TestPluralCompleteness() { testLocales.contains(locale) ? CoverageIssue.error : CoverageIssue.log; CoverageIssue needsCoverage2 = needsCoverage == CoverageIssue.error ? CoverageIssue.warn : needsCoverage; - - // if (logKnownIssue("Cldrbug:8809", "Missing plural rules/samples be and ga - // locales")) { - // if (locale.equals("be") || locale.equals("ga")) { - // needsCoverage = CoverageIssue.warn; - // } - // } PluralRulesFactory prf = PluralRulesFactory.getInstance( CLDRConfig.getInstance().getSupplementalDataInfo()); diff --git a/tools/cldr-code/src/test/java/org/unicode/cldr/unittest/TestTransforms.java b/tools/cldr-code/src/test/java/org/unicode/cldr/unittest/TestTransforms.java index 41b607844a5..d1d9a13d1f2 100644 --- a/tools/cldr-code/src/test/java/org/unicode/cldr/unittest/TestTransforms.java +++ b/tools/cldr-code/src/test/java/org/unicode/cldr/unittest/TestTransforms.java @@ -672,13 +672,6 @@ public void TestCasing() { String lithuanianSource = "I \u00CF J J\u0308 \u012E \u012E\u0308 \u00CC \u00CD \u0128 xi\u0307\u0308 xj\u0307\u0308 x\u012F\u0307\u0308 xi\u0307\u0300 xi\u0307\u0301 xi\u0307\u0303 XI X\u00CF XJ XJ\u0308 X\u012E X\u012E\u0308"; - // The following test was formerly skipped with - // !logKnownIssue("11094", "Fix ICU4J UCharacter.toTitleCase/toLowerCase for lt"). - // However [https://unicode-org.atlassian.net/browse/ICU-11094] is supposedly - // fixed in the version of ICU4J currently in CLDR, but removing the logKnownIssue - // to execute the test results in test failures, mainly for i\u0307\u0308. - // So I am changing the logKnownIssue to reference a CLDR ticket about - // investigating the test (it may be wrong). if (!logKnownIssue( "cldrbug:13313", "Investigate the Lithuanian casing test, it may be wrong")) { Transliterator ltTitle = diff --git a/tools/cldr-code/src/test/java/org/unicode/cldr/unittest/TestValidity.java b/tools/cldr-code/src/test/java/org/unicode/cldr/unittest/TestValidity.java index 9a822dfbb58..463af923030 100644 --- a/tools/cldr-code/src/test/java/org/unicode/cldr/unittest/TestValidity.java +++ b/tools/cldr-code/src/test/java/org/unicode/cldr/unittest/TestValidity.java @@ -192,10 +192,6 @@ public void TestCompatibility() { if (ALLOWED_MISSING.contains(code)) { continue; } - if (code.equals("cqzzzz") - && logKnownIssue("CLDR-16464", "Skipping cqzzzz")) { - continue; - } errln( messages, type