Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validateExtendedPublicKey needs SLIP132 and regtest #13

Closed
destrys opened this issue Jun 18, 2020 · 1 comment
Closed

validateExtendedPublicKey needs SLIP132 and regtest #13

destrys opened this issue Jun 18, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@destrys
Copy link
Contributor

destrys commented Jun 18, 2020

currently, validateExtendedPublicKey only checks for xpub and tpub for networks mainnet and testnet.

Caravan configs currently only export xpubs/tpubs, so if only validates those on reading a config, but when we make Caravan smart enough to read other wallet configs, it will be better to validate the Ypub/Zpub etc instead of converting everything to an xpub first.

And generally, unchained-bitcoins should be SLIP132 aware at a minimum.

Additionally, we should support a REGTEST network type so the apps don't have to change to specify TESTNET even though they are on regtest.

@jevidon
Copy link

jevidon commented Apr 2, 2024

Migrated issue to new repo: caravan-bitcoin/caravan#61

@jevidon jevidon closed this as not planned Won't fix, can't repro, duplicate, stale Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants