Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NUglify cannot minify CSS in Umbraco v9, throws error. #332

Closed
JasonElkin opened this issue Nov 15, 2021 · 4 comments
Closed

NUglify cannot minify CSS in Umbraco v9, throws error. #332

JasonElkin opened this issue Nov 15, 2021 · 4 comments
Labels
bug Something isn't working
Milestone

Comments

@JasonElkin
Copy link

vendr.css does not minify in Umbraco v9 (and throws an error)

Steps To Reproduce

  1. Install in a new v9 site.
  2. Set Umbraco debug to false in appsettings
  3. Load backoffice
  4. CSS bundle throws the error:

"InvalidOperationException: Expected identifier, found '>',Expected comma or open brace, found ')'"

Because of this issue with Smidge the error also causes JS to fail to load.

Expected behavior
CSS minifies and loads.

Vendr version:
2.0.3

The failing CSS in question is line 75 of vendr.css:

.matryoshka-tabs-list-wrapper:has(> .matryoshka-tabs-list > .matryoshka-tab-link:first-child + .matryoshka-tab-link[data-element="tab-vendr_variants"]) {
    display: none !important;
}

NUglify cannot handle it (have tested using Nuglify directly).

@JasonElkin JasonElkin added the bug Something isn't working label Nov 15, 2021
@JasonElkin JasonElkin changed the title CSS Breaks NUglify in Umbraco v9 NUglify cannot minify CSS in Umbraco v9, throws error. Nov 15, 2021
@mattbrailsford
Copy link
Contributor

mattbrailsford commented Nov 15, 2021

Ordinarily I'd say that this is really an issue for NUglify to fix as this is valid CSS, however, given this is Vendr v2 which only supports Umbraco v9 and Umbraco v8.17+ which both have the new tabs implementation, I think it actually makes sense for us to remove this style anyway as nobody would really be using Matroyshka in either of those two versions.

@JasonElkin
Copy link
Author

@mattbrailsford that's what I was hoping you'd say. Will still raise it as a bug with NUglify.

@mattbrailsford
Copy link
Contributor

@JasonElkin there is a new 2.0.4-beta005 on the unstable feed if you want to try that

@mattbrailsford mattbrailsford added this to the 2.0.4 milestone Nov 15, 2021
@JasonElkin
Copy link
Author

Thanks @mattbrailsford that's fixed it for our testing site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants