Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incompatible with DCC system #173

Open
jmhnilbog opened this issue Jan 23, 2022 · 2 comments
Open

incompatible with DCC system #173

jmhnilbog opened this issue Jan 23, 2022 · 2 comments

Comments

@jmhnilbog
Copy link

There's an assumption that all systems will have an 'npc' sheet class in the registerSettings() call that throws an error in the DCC system (where the npc sheet class is all-caps 'NPC').

I'd offer a PR fixing it but I'm not sure about the dnd5e assumptions in the code.

settingsConfig.js:20 Uncaught (in promise) TypeError: Cannot convert undefined or null to object
[Detected 1 package: better-rolltables]
    at Function.values (<anonymous>)
    at Settings.registerSettings (settingsConfig.js:20:35)
    at foundryReady (init.js:47:20)
    at Function._call (foundry.js:294:14)
    at Function.callAll (foundry.js:253:12)
    at Game.setupGame (foundry.js:5547:11)
    at async Game._initializeGameView (foundry.js:6479:5)
    at async Game.initialize (foundry.js:5415:5)
@EricJohnAnderson
Copy link

This is also breaking HMGold at the exact same position. Which 5e package provides the npc object?

@duprel
Copy link

duprel commented Feb 15, 2022

This is also true with Old School Essentials

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants