Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition to the ui5 element breaks is incorrect using interaction idSuffix: treeicon #394

Closed
melissaxd96 opened this issue Jan 2, 2023 · 7 comments

Comments

@melissaxd96
Copy link

melissaxd96 commented Jan 2, 2023

Describe the bug
Transition to the ui5 element breaks is incorrect using interaction idSuffix: treeicon

It is a tree table and I'm trying to access the expand icon, however looking at the _domId, it is not pointing to treeicon.

Expected behavior
It should point to the treetable's expand icon.

Screenshots
image
image
image

Runtime Env :

  • wdi5/wdio-ui5-service-version: v1.0.2
  • UI5 version: v2.14.1
  • wdio-version (output of wdio --version): v7.27.0
  • node-version (output of node --version): v18.12.1
  • Browser + Version : Chrome Version 108.0.5359.125

Internal Function: getUI5CtlForWebObj

@dominikfeininger
Copy link
Collaborator

dominikfeininger commented Jan 2, 2023

Hi @melissaxd96

maybe you can try to use the expand method on the UI5 row control. https://sapui5.hana.ondemand.com/sdk/#/api/sap.ui.table.TreeTable%23methods/expand

const row = await browser.asControl(<your row selector>)
// expand
await row.expand()

@dominikfeininger
Copy link
Collaborator

maybe @hmanchev can say something about the issue with the interaction selector.

@hmanchev
Copy link
Collaborator

hmanchev commented Jan 4, 2023

Hi all,

I am not sure that this can be related as an issue to the interaction selector. However I will forward this to our experts and will provide feedback as soon as they have any opinion.

Please note that it is still vacations period and you can expect some delays.

@kineticjs
Copy link
Collaborator

Hi @melissaxd96,

I checked that the selected icon (with idSuffix "treeicon") is only an element and not a UI5 control.
(The table may not always create UI5 controls for its internal elements if it does not need to).
The closest control containing the icon element is the parent row.

I tested the proposal of @dominikfeininger to use the table's expand method, so I can also confirm that it is a possible alternative solution, see e.g. https://jsbin.com/duwaxuqohe/edit?html,js,output

@hmanchev
Copy link
Collaborator

Did you manage to look at the answer from the OPA expert (kineticjs)?

@Siolto
Copy link
Collaborator

Siolto commented Feb 3, 2023

This issue has the same root cause as #355. For more explanation have a look at following comment.

@jdichev
Copy link
Collaborator

jdichev commented Feb 20, 2023

Hello @melissaxd96,

Which version of UI5 are you using?

Thanks and best regards,
Jordan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants