Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui5-middleware-onelogin] Calling comsapperso endpoint of Launchpad results in redirect #645

Open
gregorwolf opened this issue Aug 22, 2022 · 4 comments
Labels
help wanted Extra attention is needed question Further information is requested

Comments

@gregorwolf
Copy link

Describe the bug

I've added ui5-middleware-onelogin to the UI5 App app/webapp/item-pricing-cap-v2 in my bookshop-demo project with commit feat: add ui5-middleware-onelogin. Unfortunately sending a GET request to http://localhost:8080/comsapperso/flex/personalization/v1/data/itempricingcapv2 results in a redirect to https://60714212trial.launchpad.cfapps.us10.hana.ondemand.com/login/callback?code= which returns "Not Found".

To Reproduce

Steps to reproduce the behavior:

  1. Clone the repository https://github.com/gregorwolf/bookshop-demo
  2. Start the backend as described in the README.md
  3. Switch to the app/webapp/item-pricing-cap-v2 folder
  4. Run npm ci
  5. Run npm start
  6. Login with your S- or P-User
  7. Try to open http://localhost:8080/comsapperso/flex/personalization/v1/data/itempricingcapv2

Expected behavior

I would have expected that the cookies set by ui5-middleware-onelogin would allow me to call also this service endpoint.

Desktop (please complete the following information):

  • OS: MacOS Monterey
  • Browser Chrome
  • Version 104.0.5112.101
@uxkjaer
Copy link
Contributor

uxkjaer commented Aug 22, 2022

Hi @gregorwolf ,

I'll take a look at this soon. Just need finish a delivery first. Hope to have an update for you next week. It's curious how the onelogin should be the cause of this as it's supposed to only handle cookie injection at the beginning of serving your project. But I haven't tested it properly with a CAP application yet.

//Jakob

@uxkjaer
Copy link
Contributor

uxkjaer commented Aug 31, 2022

Hi @gregorwolf
I looked into this a bit and it seems that it's an issue with the IdP, if I try to access https://60714212trial.launchpad.cfapps.us10.hana.ondemand.com/site/trial I get the same error.
When trying on chrome, firefox and safari it will ask me for keychain access and afterwards get the oauth error.
Can you please check the settings on the IdP?

@uxkjaer uxkjaer added the question Further information is requested label Aug 31, 2022
@gregorwolf
Copy link
Author

Hi @uxkjaer,

is there any working example using SAP ID Service? I've also tried with an approuter endpoint instead of the Launchpad service. But same issue.

@petermuessig petermuessig added the help wanted Extra attention is needed label Apr 10, 2023
@petermuessig
Copy link
Member

@uxkjaer - something you wanna follow up?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants