Enable two-way UFS_FIRE coupling #1182
Open
+14
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change default of FIRE_ATM_FEEDBACK to 1.0
mkavulich
requested review from
gsketefian,
JeffBeck-NOAA,
RatkoVasic-NOAA,
BenjaminBlake-NOAA,
ywangwof,
chan-hoo,
panll,
christinaholtNOAA,
christopherwharrop-noaa,
danielabdi-noaa,
mark-a-potts,
jkbk2004,
willmayfield,
dmwright526,
gspetro-NOAA,
natalie-perlin,
EdwardSnyder-NOAA,
MichaelLueken,
rickgrubin-noaa,
BruceKropp-Raytheon,
BenKoziol-NOAA and
WeirAE
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION OF CHANGES:
Update UFS_FIRE to allow for two-way (atm --> fire + fire --> atm) coupling/feedback. Previously this setting
FIRE_ATM_FEEDBACKwas only set to 0, but now setting to a value greater than 0 will enable two-way feedback between the fire and the atmosphere.Added additional documentation for this feature, and updated one of the WE2E tests to use this setting (renamed
UFS_FIRE_multifire_one-way-coupled-->UFS_FIRE_multifire_two-way-coupled).Type of change
TESTS CONDUCTED:
Ran several tests with various values for
FIRE_ATM_FEEDBACK; ensured all of them resulted in different output (analyzed differences with ncdiff and ncview) as evidence that the feedback is working.This should not affect any non-fire runs, but I ran fundamental tests on Hera as a sanity check; all passed.
DEPENDENCIES:
None
DOCUMENTATION:
Updated Users Guide for this option.
ISSUE:
Resolves #1166
CHECKLIST