Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove useless inheritance from VGroup #3

Open
Nikhil-42 opened this issue Mar 2, 2023 · 1 comment
Open

Remove useless inheritance from VGroup #3

Nikhil-42 opened this issue Mar 2, 2023 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Nikhil-42
Copy link
Collaborator

Description

Several of the implemented Mobjects inherit from VGroup. This is typically unnecessary and can lead to strange behavior when using operators. Instead inherit from VMobject or Mobject.
@Nikhil-42 Nikhil-42 added enhancement New feature or request good first issue Good for newcomers labels Mar 2, 2023
@Nikhil-42
Copy link
Collaborator Author

Make sure to verify that the functionality of the Mobject really doesn't depend on the VGroup inheritance. Namely, look at the methods and operators that VGroup adds (in vectorized_mobject.py) and see if they make sense to keep. For example, it doesn't really make sense that adding an Mobject to an MArrayElement links their positions, rotations, and scale together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Nikhil-42