Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Music Player Button State Inconsistent When Switching Pages #42

Open
AntonCSalvador opened this issue Sep 3, 2024 · 5 comments
Open
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed medium

Comments

@AntonCSalvador
Copy link
Contributor

Music Player Button State Inconsistent When Switching Pages

Description

On the BytesOfLove website, there is a music player button located at the bottom left of the screen. However, when switching between pages or tabs within the site, the state of the button (whether the music is playing or paused) does not persist. This requires users to manually re-click the button to continue or pause the music, which disrupts the user experience.

Steps to Reproduce

  1. Go to the BytesOfLove website.
  2. Click the music player button at the bottom left to start playing music.
  3. Navigate to a different page or switch tabs within the website.
  4. Observe that the music stops, and the button does not reflect the previous state (playing/paused).

Expected Behavior

  • The state of the music player button should persist when switching between pages or tabs on the website.
  • If music is playing, it should continue to play without interruption when navigating to different pages.
  • If music is paused, it should remain paused when switching pages, and the button should reflect the paused state.

Possible Solution

  • Implement a persistent state management solution (e.g., using local storage, session storage, or a global state management system like Redux) to ensure the music player's state is maintained across page navigations.
  • Ensure the music playback is not interrupted when users navigate between pages.

Additional Context

This issue affects the continuity of the user experience, especially for users who enjoy background music while browsing the website. It is also important to adhere to web laws.

@AntonCSalvador AntonCSalvador added enhancement New feature or request help wanted Extra attention is needed medium labels Sep 5, 2024
@StrBoll
Copy link
Contributor

StrBoll commented Sep 5, 2024

Im on it!

@AntonCSalvador
Copy link
Contributor Author

Thank you @StrBoll ! I will assign it right now

@StrBoll
Copy link
Contributor

StrBoll commented Sep 8, 2024

Committed the fixes but cant push to a new branch for the issue cause I don't have permissions.

edit -- nvm figured it out --

StrBoll added a commit to StrBoll/BytesOfLoveWebsite that referenced this issue Sep 8, 2024
@AntonCSalvador
Copy link
Contributor Author

@StrBoll Hey! great work! I tested in a bit and looks good. Can you open a pull request?

@StrBoll StrBoll mentioned this issue Sep 9, 2024
@StrBoll
Copy link
Contributor

StrBoll commented Sep 9, 2024

Pull request created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed medium
Projects
None yet
Development

No branches or pull requests

2 participants