UFAL/The files are not rendered in the Item UI (#752)

* Do not commit a session during processing the previews. Catch the error when the ZIP is broken because it wont render files in the UI. * Fixed checkstyle issues
ufal · Sep 12, 2024 · 218f7f2 · 218f7f2
1 parent 47b45b6
commit 218f7f2
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/...-webapp/src/main/java/org/dspace/app/rest/repository/MetadataBitstreamRestRepository.java b/...-webapp/src/main/java/org/dspace/app/rest/repository/MetadataBitstreamRestRepository.java
@@ -173,7 +173,6 @@ public Page<MetadataBitstreamWrapperRest> findByHandle(@Parameter(value = "handl
                         for (FileInfo fi : fileInfos) {
                             createPreviewContent(context, bitstream, fi);
                         }
-                        context.commit();
                     } else {
                         for (PreviewContent pc : prContents) {
                             fileInfos.add(createFileInfo(pc));
@@ -186,6 +185,7 @@ public Page<MetadataBitstreamWrapperRest> findByHandle(@Parameter(value = "handl
                 metadataValueWrappers.add(bts);
                 rs.add(metadataBitstreamWrapperConverter.convert(bts, utils.obtainProjection()));
             }
+            context.commit();
         }
 
         return new PageImpl<>(rs, pageable, rs.size());
@@ -318,7 +318,11 @@ private List<FileInfo> processInputStreamToFilePreview(Context context, Bitstrea
             String data = "";
             if (bitstream.getFormat(context).getMIMEType().equals("application/zip")) {
                 data = extractFile(inputStream, "zip");
-                fileInfos = FileTreeViewGenerator.parse(data);
+                try {
+                    fileInfos = FileTreeViewGenerator.parse(data);
+                } catch (Exception e) {
+                    log.error("Cannot extract file content because: {}", e.getMessage());
+                }
             } else if (bitstream.getFormat(context).getMIMEType().equals("application/x-tar")) {
                 ArchiveInputStream is = new ArchiveStreamFactory().createArchiveInputStream(ArchiveStreamFactory.TAR,
                         inputStream);