Breaks in 24-25 year for reports #66
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbrxyz
requested changes
Jul 30, 2024
Comment on lines
-714
to
-730
| @run_on_weekday(calendar.FRIDAY, 12, 0, check=is_active) | ||
| async def post_reminder(self): | ||
| general_channel = self.bot.general_channel | ||
| return await general_channel.send( | ||
| f"{self.bot.egn4912_role.mention}\nHey everyone! Friendly reminder to submit your weekly progress reports by **Sunday night at 11:59pm**. You can submit your reports in the {self.bot.member_services_channel.mention} channel. If you have any questions, please contact your leader. Thank you!", | ||
| ) | ||
|
|
||
| async def safe_col_values( | ||
| self, | ||
| ws: gspread_asyncio.AsyncioGspreadWorksheet, | ||
| column: int, | ||
| ) -> list[str]: | ||
| names = await ws.col_values(column) | ||
| if not isinstance(names, list): | ||
| raise RuntimeError("Column is missing!") | ||
| return [n or "" for n in names] | ||
|
|
Comment on lines
+90
to
+95
| start_date = self._start_date() | ||
| current_week = 0 | ||
| while current_week < self.week: | ||
| if not self._is_break(start_date): | ||
| current_week += 1 | ||
| start_date += datetime.timedelta(days=7) |
There was a problem hiding this comment.
I think this approach is a good start, but might have a bit of an issue. It appears this implementation completely ignores break weeks (ie, it pretends break weeks don't exist). This isn't really what we want, as we want people to be able to submit reports during break weeks, but we just don't want to make them required.
You probably don't even need to change anything in the calculation of weeks. You just need to change the behavior of the reports system:
- The reports submission button should display "Submit your report! (optional due to break)" (relevant code)
- Only the first individual reminder should go off, so the other two will need to check whether we are currently in a break week and then disable their behavior.
- Rather than sending out the grading form to leaders, everyone should be automatically graded green. (relevant function)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.