Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor parseSection and parseLecture #63

Open
nathan-inge opened this issue Mar 14, 2018 · 1 comment
Open

Refactor parseSection and parseLecture #63

nathan-inge opened this issue Mar 14, 2018 · 1 comment

Comments

@nathan-inge
Copy link
Contributor

Within UCSBSearchCurriculum.java we removed all the old substring methods that were left over from our previous refactor. Then, following the suggestion of the software engineer from TheTradeDesk that we worked with, we refactored parseSection and parseLecture to just use JSOUP to parse the individual course row tags.

This allows us to limit our use of substring to very small, specific strings, making the parsing more reliable and safer.
This was referenced Mar 14, 2018
Open
Merged
@CDLlo
Copy link
Contributor

CDLlo commented Mar 16, 2018

W18 OK 200 points

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@CDLlo @nathan-inge