-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Encapsulate variables and use getters & setters #42
Comments
joyoyoyoyoyo
changed the title
Encapsulate variables and use getters or setters
Encapsulate variables and use getters & setters
Feb 5, 2016
200 pts |
Approved: 200 pts |
F16 OK |
W18 Ok 200 pts |
This fix actually requires more dedicate care as there are 25 classes total with even more variables. I suggest to make this a 300 pts issue. |
If you decide to fix this issue, I'll keep that in mind during feedback. |
Merged
Implemented in w18 branch. Feel free to look over their code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
No encapsulation is being used in this project.
Almost every variable is public. Getters and setters could be used instead.
This does not enforce separation of concerns.
Example code:
The text was updated successfully, but these errors were encountered: