Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typos/small visual things #262

Open
5 tasks done
jgibson517 opened this issue May 22, 2024 · 3 comments · Fixed by #273
Open
5 tasks done

typos/small visual things #262

jgibson517 opened this issue May 22, 2024 · 3 comments · Fixed by #273

Comments

@jgibson517
Copy link
Contributor

jgibson517 commented May 22, 2024

@claireboyd the about and education pages look great! wanted to flag some small things that seem easy to fix:

On the education page:

  • - "at theFederal Register. " missing space in "What is public commenting?" section
  • - nit-picky: the US Federal Commenting Process graphic is a little small compared to the rest of the page

On the about page:

  • - "from the regulations.gov ," extra space in the "How we make public commenting more accessible"

  • - "Software Engineering for Civic Tech ," "GitHub ." extra spaces in the About Us

  • Can we also link to our docs site (https://uchicago-capp-30320.github.io/CivicLens/) in the about page.

@claireboyd
Copy link
Contributor

how should we pull the date on the search page? right now its this:

    # find date for when one doc in the db was last updated (MVP technique)
    try:
        last_updated = (
            Document.objects.all()
            .order_by(
                "-last_modified_date",
            )
            .values("last_modified_date")[0:1][0]["last_modified_date"]
        )
    except IndexError:
        last_updated = None

is this the right approach?

@abejburton
Copy link
Contributor

abejburton commented May 22, 2024

  • 'at the[Federal Register.]' on the home page needs a space after 'the'.
  • Comment methods boxes are different sizes - how difficult is this to fix?
  • regulations.gov is not hyperlinked everywhere on the home page.
  • I like the red and blue CivicLens on the about page. Should this be consistent throughout the site?
  • Suggested edit on methods page for representative comments -> change the "our goal" sentence to this: Our goal is to make it easier to quickly understand a range of perspectives on a given topic.
  • Suggested edit on methods page for comment topics and sentiment -> (how positive or negative the tone) to (how positive or negative the tone is)

@GregoryHo88
Copy link
Contributor

GregoryHo88 commented May 22, 2024

On the Learn page.

Why does CivicLens exist?
"...We nightly collect data from regulations.gov..."

  • Nightly collect feels weird. Propose changing to "We collect data from regulations.gov nightly...

@claireboyd claireboyd linked a pull request May 22, 2024 that will close this issue
@jgibson517 jgibson517 reopened this May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants