Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove default: None from rock-version-schema #825

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Remove default: None from rock-version-schema #825

merged 1 commit into from
Dec 9, 2024

Conversation

rudra-iitm
Copy link
Contributor

Remove default: None from rock-version-schema missed in PR #817

@rudra-iitm
Copy link
Contributor Author

@sergio-costas ....

sergio-costas
sergio-costas approved these changes Dec 9, 2024
View reviewed changes
Copy link
Collaborator

@sergio-costas sergio-costas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This patch makes sense: setting the default to 'None' as a string break the tests.

@sergio-costas sergio-costas merged commit ea0645b into ubuntu:stable Dec 9, 2024
@sergio-costas
Copy link
Collaborator

Good catch: I clearly forgot to remove that in my previous patch.

@rudra-iitm rudra-iitm deleted the fix-none-default branch December 9, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergio-costas sergio-costas sergio-costas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rudra-iitm @sergio-costas