Use None instead of string 'None' #817
Merged
+5
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think there is an issue when using None instead of 'None', as action.yml sends 'None' when an argument is not passed. We can't pass None as the default value in action.yml because it breaks. |
|
I updated the action.yml file. Now it should manage that case without problem. |
Two command line options use the string 'None' instead of the native type None as the default value. This PR changes this.
The `version-schema` and `rock-version-schema` must be passed only when defined.
sergio-costas
force-pushed
the
fix-none-default
branch
from
91e0358 to
3439c7d
Compare
|
Hi @rudra-iitm . Could you review this patch, please? I want to be sure that it doesn't break anything. |
|
@sergio-costas , this looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two command line options use the string 'None' instead of the native type None as the default value.
This PR changes this.