Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

just nvidia toggle #182

Closed
castrojo opened this issue Jan 4, 2024 · 3 comments
Closed

just nvidia toggle #182

castrojo opened this issue Jan 4, 2024 · 3 comments
Assignees
@KyleGospo
Labels
help wanted Extra attention is needed

Comments

@castrojo
Copy link
Member

castrojo commented Jan 4, 2024

We should make it so a user can toggle inbetween their given image's nvidia image. When nvk lands people will want to try it but also be able to check out the performance in the nvidia driver.

It's annoying to remember and type out the long rebase command, we'll basically have an out of the box nvidia driver toggle switch. Then every time there's a new kernel release our users can follow along with both the upstream development but be able to easily swap out to the proprietary driver.

That's awesome. Assigning @KyleGospo to outline how it should be done, and this one's gonna be hot so if you wanna work on it, self assign!
@castrojo castrojo added the help wanted Extra attention is needed label Jan 4, 2024
@castrojo
Copy link
Member Author

castrojo commented Jan 4, 2024

The -dx toggle in bluefin does this already, I think we can adapt that for this?

@HikariKnight
Copy link
Member

this should be easy enough to add to #181 as just a new menu entry and quick choice :) or just add a new command just toggle-nvk or something 😄

HikariKnight added a commit that referenced this issue Jan 11, 2024
@HikariKnight
feat(just): add toggle-nvk, addresses #182
195893f
github-merge-queue bot pushed a commit that referenced this issue Jan 12, 2024
@HikariKnight
feat(just): combine several just commands into toggles or choices (#181)
1399871 
* chore: merge install/remove-distrobox-git

* chore: merge enable/disable-updates

* chore: correct wording in description of distrobox-git

* chore(just): merge ublue/stock-gamepads and enable/disable-broadcom-wl

* chore(just): combine and merge all the nix recipes

* chore(just): remove empty lines that were used for readability while writing the just recipes

* chore(just): remove leftover spaces from before reorg

* chore(just): improve description wording for setup-distrobox-git and change brew-remove to remove-brew

* chore(just): format the message for configure-gamepads to look better

* chore(just): change gamepad description to be more clear

* chore(just): merge nvidia recipes into configure-nvidia

* chore(just): change fixscreenshare to fix-screenshare to conform with naming scheme

* chore(just): add some bold text for title or install state

* feat(just): add quick options for use in yafti

* chore(just): fix formating for just

* chore(just): add missing quick options for setup-nix

* chore(just): add aliases for recipes

* chore(just): add empty line between alias and recipe description

* chore(just): added missing empty line for upgrade alias

* chore: Always use #!/usr/bin/bash

* chore(just): fix conditions to be lowercase for enable/disable and install/remove

* chore(just): standardize choice recipe ARG as ACTION

* feat(just): add toggle-nvk, addresses #182

* chore(just): Add message about what to do after running enroll-secure-boot-key
@HikariKnight
Copy link
Member

This has been added by #181 and also supports startingpoint images (in case user has made an -nvidia image and non nvidia image)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KyleGospo KyleGospo

Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@castrojo @HikariKnight @KyleGospo