From 86e5028a6c3e6c4836feebda2ef36465e9d151b3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Myka=C3=ABl=20Lemieux-Lafontaine?= Date: Fri, 25 Oct 2024 11:24:27 -0400 Subject: [PATCH] Fix naming convention --- NGitLab.Mock/Clients/PipelineScheduleClient.cs | 2 +- NGitLab/IPipelineScheduleClient.cs | 3 +-- NGitLab/Impl/PipelineScheduleClient.cs | 2 +- NGitLab/PublicAPI.Unshipped.txt | 2 +- 4 files changed, 4 insertions(+), 5 deletions(-) diff --git a/NGitLab.Mock/Clients/PipelineScheduleClient.cs b/NGitLab.Mock/Clients/PipelineScheduleClient.cs index 846f4904..5325b16e 100644 --- a/NGitLab.Mock/Clients/PipelineScheduleClient.cs +++ b/NGitLab.Mock/Clients/PipelineScheduleClient.cs @@ -47,7 +47,7 @@ public IEnumerable All public GitLabCollectionResponse GetAllAsync() => GitLabCollectionResponse.Create(All); - public GitLabCollectionResponse GetAllSchedulePipelines(int id) + public GitLabCollectionResponse GetAllSchedulePipelinesAsync(int id) { using (Context.BeginOperationScope()) { diff --git a/NGitLab/IPipelineScheduleClient.cs b/NGitLab/IPipelineScheduleClient.cs index aff90078..b6d3704d 100644 --- a/NGitLab/IPipelineScheduleClient.cs +++ b/NGitLab/IPipelineScheduleClient.cs @@ -38,7 +38,6 @@ public interface IPipelineScheduleClient /// Get all pipelines triggered by a pipeline schedule in a project. /// /// Schedule Id - /// /// - GitLabCollectionResponse GetAllSchedulePipelines(int id); + GitLabCollectionResponse GetAllSchedulePipelinesAsync(int id); } diff --git a/NGitLab/Impl/PipelineScheduleClient.cs b/NGitLab/Impl/PipelineScheduleClient.cs index 48d906c7..5b16f766 100644 --- a/NGitLab/Impl/PipelineScheduleClient.cs +++ b/NGitLab/Impl/PipelineScheduleClient.cs @@ -27,7 +27,7 @@ public PipelineScheduleClient(API api, ProjectId projectId) public GitLabCollectionResponse GetAllAsync() => _api.Get().GetAllAsync(_schedulesPath); - public GitLabCollectionResponse GetAllSchedulePipelines(int id) + public GitLabCollectionResponse GetAllSchedulePipelinesAsync(int id) => _api.Get().GetAllAsync($"{_schedulesPath}/{id.ToStringInvariant()}/pipelines"); public Task GetByIdAsync(int id, CancellationToken cancellationToken = default) diff --git a/NGitLab/PublicAPI.Unshipped.txt b/NGitLab/PublicAPI.Unshipped.txt index 4f90dfbc..1b3fcdbe 100644 --- a/NGitLab/PublicAPI.Unshipped.txt +++ b/NGitLab/PublicAPI.Unshipped.txt @@ -1048,7 +1048,7 @@ NGitLab.IPipelineClient.UpdateMetadataAsync(int pipelineId, NGitLab.Models.Pipel NGitLab.IPipelineScheduleClient NGitLab.IPipelineScheduleClient.All.get -> System.Collections.Generic.IEnumerable NGitLab.IPipelineScheduleClient.GetAllAsync() -> NGitLab.GitLabCollectionResponse -NGitLab.IPipelineScheduleClient.GetAllSchedulePipelines(int id) -> NGitLab.GitLabCollectionResponse +NGitLab.IPipelineScheduleClient.GetAllSchedulePipelinesAsync(int id) -> NGitLab.GitLabCollectionResponse NGitLab.IPipelineScheduleClient.GetByIdAsync(int id, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) -> System.Threading.Tasks.Task NGitLab.IPipelineScheduleClient.this[int id].get -> NGitLab.Models.PipelineSchedule NGitLab.IProjectBadgeClient