From 860695d7911a736bd058955f2ec917bdd314cb6a Mon Sep 17 00:00:00 2001 From: Fernando Date: Wed, 6 Mar 2024 13:29:11 +0900 Subject: [PATCH 1/4] chore: moved knip configuration --- knip.ts => .github/knip.ts | 2 +- package.json | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) rename knip.ts => .github/knip.ts (90%) diff --git a/knip.ts b/.github/knip.ts similarity index 90% rename from knip.ts rename to .github/knip.ts index 57b5e39..a749511 100644 --- a/knip.ts +++ b/.github/knip.ts @@ -8,4 +8,4 @@ const config: KnipConfig = { ignoreDependencies: [], }; -export default config; \ No newline at end of file +export default config; diff --git a/package.json b/package.json index 72e158a..5e66a96 100644 --- a/package.json +++ b/package.json @@ -15,8 +15,8 @@ "format:lint": "eslint --fix .", "format:prettier": "prettier --write .", "format:cspell": "cspell **/*", - "knip": "knip", - "knip-ci": "knip --no-exit-code --reporter json", + "knip": "knip --config .github/knip.ts", + "knip-ci": "knip --no-exit-code --reporter json --config .github/knip.ts", "prepare": "husky install", "test": "jest --setupFiles dotenv/config --coverage", "cy:open": "cypress open", From 79c9b1c5f798bc0f093d50d17834974c4822e828 Mon Sep 17 00:00:00 2001 From: Fernando Date: Wed, 6 Mar 2024 13:33:23 +0900 Subject: [PATCH 2/4] chore: workflow dispatch for knip --- .github/workflows/knip.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/knip.yml b/.github/workflows/knip.yml index df68bda..b686ba2 100644 --- a/.github/workflows/knip.yml +++ b/.github/workflows/knip.yml @@ -2,6 +2,7 @@ name: Knip on: pull_request: + workflow_dispatch: permissions: write-all @@ -27,4 +28,4 @@ jobs: comment_id: ${{ github.workflow }}-reporter command_script_name: knip-ci annotations: true - ignore_results: false \ No newline at end of file + ignore_results: false From 0ac9d659923904dcec8bce83c67d592b2972e5f3 Mon Sep 17 00:00:00 2001 From: Fernando Date: Wed, 6 Mar 2024 13:53:17 +0900 Subject: [PATCH 3/4] chore: changed action target to pull_request_target --- .github/workflows/jest-testing.yml | 2 +- .github/workflows/knip.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/jest-testing.yml b/.github/workflows/jest-testing.yml index b8a785d..1671cd4 100644 --- a/.github/workflows/jest-testing.yml +++ b/.github/workflows/jest-testing.yml @@ -1,7 +1,7 @@ name: Run Jest testing suite on: workflow_dispatch: - pull_request: + pull_request_target: types: [ opened, synchronize ] env: diff --git a/.github/workflows/knip.yml b/.github/workflows/knip.yml index b686ba2..50a1a2a 100644 --- a/.github/workflows/knip.yml +++ b/.github/workflows/knip.yml @@ -1,7 +1,7 @@ name: Knip on: - pull_request: + pull_request_target: workflow_dispatch: permissions: write-all From 85f20d42183915c9280b7789cd3469e440d50e55 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E3=82=A2=E3=83=AC=E3=82=AF=E3=82=B5=E3=83=B3=E3=83=80?= =?UTF-8?q?=E3=83=BC=2Eeth?= <4975670+pavlovcik@users.noreply.github.com> Date: Wed, 6 Mar 2024 15:16:58 +0900 Subject: [PATCH 4/4] ci(cspell): fix --- tests/__mocks__/db.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/__mocks__/db.ts b/tests/__mocks__/db.ts index 50394c1..7df690c 100644 --- a/tests/__mocks__/db.ts +++ b/tests/__mocks__/db.ts @@ -1,3 +1,4 @@ +// cSpell:disable import { factory, primaryKey } from "@mswjs/data"; /**