Output deployment URL

[rndquu]

Original comment

We should pass cloudflare deployment preview to cypress workflow here.

What should be done:

1. Update current github action to return deployment URL in output (example)
2. Update all ubiquity repos which use cypress workflow and set FRONTEND_URL env variable to https://github.com/ubiquity/cloudflare-deploy-action output

[0x4007]

Prob should be high priority if it's CI for all repos

[rndquu]

Prob should be high priority if it's CI for all repos

I'll fix it as part of #1, this issue more of a reminder

[0xJoichiro]

@rndquu is this issue finished in #1 ?

[rndquu]

@rndquu is this issue finished in #1 ?

No, you're free to take it

[0xJoichiro]

@rndquu is this issue finished in #1 ?

No, you're free to take it

understood,how should i test the same?

[0xJoichiro]

We can start with getting DEPLOYMENT_URL from the bash script for deploying to cloudflare

cloudflare-deploy-action/.github/cloudflare-deploy.sh

Line 39 in 5454d2d

echo "DEPLOYMENT_URL=$url" >> "$GITHUB_ENV"

Set an output up for downstream actions

        echo "::set-output name=deploy_url::${{ env.DEPLOYMENT_URL }}"

Then could get that back as an output from something like here
=>

       url: ${{steps.deploy.outputs.deploy_url}}

please confirm this logic and i'll make the PR asap

[rndquu]

We can start with getting DEPLOYMENT_URL from the bash script for deploying to cloudflare

cloudflare-deploy-action/.github/cloudflare-deploy.sh

Line 39 in 5454d2d

echo "DEPLOYMENT_URL=$url" >> "$GITHUB_ENV"

Set an output up for downstream actions

        echo "::set-output name=deploy_url::${{ env.DEPLOYMENT_URL }}"

Then could get that back as an output from something like here =>

       url: ${{steps.deploy.outputs.deploy_url}}

please confirm this logic and i'll make the PR asap

Sounds good

[rndquu]

@rndquu is this issue finished in #1 ?

No, you're free to take it

understood,how should i test the same?

Not sure what you mean by "test the same"

[0xJoichiro]

@rndquu is this issue finished in #1 ?

No, you're free to take it

understood,how should i test the same?

Not sure what you mean by "test the same"

I meant to ask,how would we test this workflow in action?

[rndquu]

@rndquu is this issue finished in #1 ?

No, you're free to take it

understood,how should i test the same?

Not sure what you mean by "test the same"

I meant to ask,how would we test this workflow in action?

Test locally first (i.e. in one of your workflows)

[Sadaf-A]

/start

[ubiquibot]

Warning!	This task was created over 120 days ago. Please confirm that this issue specification is accurate before starting.
Deadline	Fri, Jul 12, 3:37 PM UTC
Registered Wallet	0x0BEd00438D57d07E3667b85Fa8EB86Af147C7025

Tips:

• Use /wallet 0x0000...0000 if you want to update your registered payment wallet address.
• Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
• Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the task.

[rndquu]

@gentlementlegen It seems we may close this one as "not planned" since deployment URL may be fetched from env variable + cypress seems to be working fine locally

[gentlementlegen]

Agreed, and so far we've been able to fake auth even within Cypress for projects like work.ubq.fi so this is no relevant for now.

[ubiquity-os]

# Issue was not closed as completed. Skipping.