Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tool window contents are not properly disposed #7

Open
kpatenio opened this issue Aug 22, 2020 · 0 comments
Open

Tool window contents are not properly disposed #7

kpatenio opened this issue Aug 22, 2020 · 0 comments
Assignees
Labels
bug Something isn't working documentation Improvements or additions to documentation initial plugin (explain merge conflict)

Comments

@kpatenio
Copy link
Collaborator

The tool window doesn't seem to be properly disposed once a merge conflict is resolved or aborted. This can potentially lead to memory leaks if the IDE is used for a long duration. Will need to also document how we should dispose of certain objects.

Example 1

ConflictRegion instances from file1 are kept in memory whenever open file2, despite their nodes not being displayed on the tool window. The tree then instantiates ConflictRegion instances for the file2 and displays them. Once a merge conflict is completely resolved or aborted, the ConflictRegions still remain in memory.

Example 2

After aborting or resolving a merge conflict, an instance of the tool window remains in memory. Upon triggering the merge conflict again, a new tool window instance is created while the previous one still remains in memory.

@kpatenio kpatenio added bug Something isn't working documentation Improvements or additions to documentation labels Aug 22, 2020
@kpatenio kpatenio self-assigned this Aug 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation initial plugin (explain merge conflict)
Projects
None yet
Development

No branches or pull requests

1 participant