Sarah afiya/issue 21/improve api extraction #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # documentation_quality_analysis/analyze_library/signature_matcher/python_signature_matcher.py
snadi
approved these changes
Sep 20, 2023
| else: | ||
| method = _get_parsed_method_details(method=description, class_name=class_name) | ||
| signatures.append(method) | ||
|
|
There was a problem hiding this comment.
does it makes sense to somehow keep this "more generic" parsing mechanism still available in the code? For example, have different parsing strategies that can be called/used, and then just use the specific one for the format?
| # else: | ||
| # method = _get_parsed_method_details(method=description, class_name=class_name) | ||
| # if method: | ||
| # signatures.append(method) |
There was a problem hiding this comment.
can you remove the commented code? See above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the function 'get_signatures_from_section' to get APIs from a fixed HTML format and updated unit test to cover all the intended functionalities
Solves #21