Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can Java version be updated to match the fields available in NodeJS version? #13

Open
milespoindexter opened this issue Dec 9, 2015 · 2 comments

Comments

@milespoindexter
Copy link

Can this get all of the fields that the NodeJS version does?
Do they both use the same regexes.yaml?
If so, how hard would it be to update it to get the same data results?

For instance, some missing fields are:
ua.browser.version (just combine the major and minor, maybe patch results?)
ua.device.type (i.e. desktop, mobile, tablet, etc) (basically device category)
ua.device.model (i.e. iPhone, etc.) (for this I'm currently using device.family)
ua.os.version (just combine the major and minor, maybe patch results?)
ua.device.vendor (i.e. Apple, Microsoft, etc)
ua.cpu.architecture (i.e. AMD64, etc.)

@milespoindexter
Copy link
Author

Hi, sorry, I have better information now. It turns out the NodeJS module I was referring to is NOT under the ua-parser umbrella and uses its own internal regex, which seems to parse the UA string more effectively: https://github.com/faisalman/ua-parser-js. Going to see if I can port it to Java. But worth a look to incorporate their regex into your regexes.yaml . . .

@dularion
Copy link

dularion commented Feb 2, 2017

I also need the ua.device.type

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants