From 9902b41724c23021efe984941f81ca3ed44d1b73 Mon Sep 17 00:00:00 2001 From: Louis Barthonet Date: Wed, 21 Feb 2024 17:43:07 +0100 Subject: [PATCH] fix: ensure Ladybird regex works with newer UAs --- regexes.yaml | 4 ++-- tests/test_ua.yaml | 6 ++++++ 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/regexes.yaml b/regexes.yaml index cea1ea13..f09bbbee 100644 --- a/regexes.yaml +++ b/regexes.yaml @@ -1029,8 +1029,8 @@ user_agent_parsers: - regex: '\b(HTTrack) (\d+)\.(\d+)(?:[\.\-](\d+)|)' # Ladybird Browser (https://ladybird.dev) - # https://github.com/SerenityOS/serenity/blob/8da9ff24e4e720b1e80a027f09c419ac9503f896/Userland/Libraries/LibWeb/Loader/ResourceLoader.h#L52 - - regex: 'LibWeb\+LibJS\/\d+\.\d+ (Ladybird)\/(\d+)\.(\d+)' + # https://github.com/SerenityOS/serenity/blob/6a662e0d43810c1dbd56fbf0c123f258aa1d694e/Userland/Libraries/LibWeb/Loader/ResourceLoader.h#L64 + - regex: '(Ladybird)\/(\d+)\.(\d+)' # MullvadBrowser (https://mullvad.net/en/browser) - regex: '(MullvadBrowser)/(\d+)(?:\.(\d+)|)(?:\.(\d+)|)' diff --git a/tests/test_ua.yaml b/tests/test_ua.yaml index 5ae67802..1a6c8f8e 100644 --- a/tests/test_ua.yaml +++ b/tests/test_ua.yaml @@ -8670,6 +8670,12 @@ test_cases: minor: '0' patch: + - user_agent_string: 'Mozilla/5.0 (Linux; x86_64) Ladybird/1.0' + family: 'Ladybird' + major: '1' + minor: '0' + patch: + - user_agent_string: 'surveyon/2.7.6 Mobile (Android: 11; MODEL:CPH2127; PRODUCT:CPH2127T2; MANUFACTURER:OPPO;)' family: 'Surveyon' major: '2'