Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

一个注释问题 #1

Open
zhchyang2004 opened this issue Aug 21, 2020 · 3 comments
Open

一个注释问题 #1

zhchyang2004 opened this issue Aug 21, 2020 · 3 comments

Comments

@zhchyang2004
Copy link

zhchyang2004 commented Aug 21, 2020

你好! 代码中的注释极大地提高了学习效率.

下面几行关于平移量的注释中, 都应该是't_w_c', 而不是't_w_i'或't_w_b'吧?

https://github.com/tzhangZJU/VINS_Fusion-comment/blob/master/vins_estimator/src/estimator/estimator.cpp#L720
https://github.com/tzhangZJU/VINS_Fusion-comment/blob/master/vins_estimator/src/estimator/estimator.cpp#L749
https://github.com/tzhangZJU/VINS_Fusion-comment/blob/master/vins_estimator/src/estimator/estimator.cpp#L761

谢谢!

@tzhangZJU
Copy link
Owner

你好,VINS系统建模过程中选择了IMU坐标系作为body坐标系,因此i与b等价的;另外,代码720那行,作者没有考虑camera与IMU之间的平移,PS部分进行了说明

@zhchyang2004
Copy link
Author

zhchyang2004 commented Sep 12, 2020

感谢回复! 720行的T_pnp 是用pnp得到的平移量(即相机之间的位置关系,和imu或body无关), 所以这里的注释还应该是't_w_c'(即和718行的注释一致)吧? 这要比写成't_w_i'好吧?

@tzhangZJU
Copy link
Owner

是的,这里这样注释也是为了与上面旋转矩阵一致(frame_it->second.R = R_pnp * RIC[0].transpose(); ),719行旋转矩阵乘了R_c_i,因此最终得到R_w_i;关于平移,你那样理解也是我可以的,我这里这样注释只是为了与上面旋转矩阵一致。都是细节哈,理解就ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants