Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cluster-specific protocol should not be included in Core's protocol #113

Open
lolski opened this issue Jan 25, 2021 · 2 comments
Open

Cluster-specific protocol should not be included in Core's protocol #113

lolski opened this issue Jan 25, 2021 · 2 comments

Comments

@lolski
Copy link
Member

lolski commented Jan 25, 2021

Problem to Solve

[This issue has been generalised based on Alex's message below]

The protocol spec includes definitions specific to Core and Cluster in one place. However, this exposes Cluster APIs on the Core server that could accidentally be implemented and additionally represents a domain leak. The Cluster protocol should be separate and extend the Core protocol in a separately released package.

@lolski lolski self-assigned this Jan 25, 2021
@lolski lolski changed the title Do not allow sending read replica request to Grakn Core server Split read replica definition into its own definition only visible to Grakn Cluster Jan 25, 2021
@lolski lolski changed the title Split read replica definition into its own definition only visible to Grakn Cluster Make read replica definition part of Grakn Cluster specific definitions Jan 25, 2021
@lolski lolski changed the title Make read replica definition part of Grakn Cluster specific definitions Make read secondary replica type part of Grakn Cluster specific definitions Jan 25, 2021
@alexjpwalker
Copy link
Member

alexjpwalker commented Apr 6, 2021

read_any_replica is now part of the Options message, however the general message of this issue (it's visible to Core clients) still applies.

@flyingsilverfin flyingsilverfin changed the title Make read secondary replica type part of Grakn Cluster specific definitions Read secondary replica option should be part of cluster-specific protocol Jan 10, 2023
@flyingsilverfin flyingsilverfin changed the title Read secondary replica option should be part of cluster-specific protocol Cluster-specific protocol should not be included in Core's protocol Jan 10, 2023
@flyingsilverfin
Copy link
Member

Note: since we are planning on absorbing the protocol into the server repositories, this split should occur naturally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants