Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource leak in TcpChannel when opening and closing TCP Proxies. #90

Open
scottcnevin opened this issue Apr 4, 2024 · 3 comments
Open

Comments

@scottcnevin
Copy link

In TcpChannel we found that opening and closing TCP Proxies between client and server would leak resources
on the Gen2 heap that were never reclaimed. We have an application that grew to a run-time foot-print of 5 Gb! Running Redgate ANTS memory profiler found a set of objects that were being retained in Gen2 due to a number of references related to the SocketAsyncEventArgs. In the changes, each step in this was able to finally get a flat memory profile when making and breaking connections between client and server.

authlogics#1

@tylerje
Copy link
Member

tylerje commented Apr 4, 2024

Love it. Submit the PR and I'll run some tests locally and if everything checks out, I'll get a new version of the package out asap.

@scottcnevin
Copy link
Author

scottcnevin commented Apr 8, 2024

Tyler -- not really sure what to do at this point. I opened the PR and made the changes. Not sure how to "submit" the PR at this point on github.

authlogics#1

@tylerje
Copy link
Member

tylerje commented Apr 8, 2024

@scottcnevin the PR you created and referenced is into your own fork. As such, I cannot approve that PR nor would it land in the origin in my repo. See the doc:
https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request-from-a-fork

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants