Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Last simplified queries are not aggregating correctly per user events #2

Open
txomon opened this issue Jul 10, 2018 · 0 comments · May be fixed by #15
Open

Last simplified queries are not aggregating correctly per user events #2

txomon opened this issue Jul 10, 2018 · 0 comments · May be fixed by #15
Assignees
@dtgoitia
Labels
kind/I&C Code, Infrastructure, Tests, everything that is not feature related, but more code related size/S T-shit size for tasks that take less than a day tech/SQL This knowledge involves mostly SQL type/bug Something isn't working

Comments

@txomon
Copy link
Owner

txomon commented Jul 10, 2018

There is a testcase where the function query_simplified_user_actions fails to run. This is because the aggregation of the events simplifies between upvotes, downvotes and skips, not only between upvotes and downvotes, leaving skips unsimplified.

Also, anonymous actions should not be simplified.
@txomon txomon added the tech/SQL This knowledge involves mostly SQL label Jul 10, 2018
@txomon txomon added kind/I&C Code, Infrastructure, Tests, everything that is not feature related, but more code related type/bug Something isn't working labels Jul 10, 2018
@txomon txomon added the size/S T-shit size for tasks that take less than a day label Jul 12, 2018
@dtgoitia dtgoitia linked a pull request Jul 23, 2018 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dtgoitia dtgoitia

Labels
kind/I&C Code, Infrastructure, Tests, everything that is not feature related, but more code related size/S T-shit size for tasks that take less than a day tech/SQL This knowledge involves mostly SQL type/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: query_simplified_user_actions and add test cases dtgoitia/mosbot
2 participants
@txomon @dtgoitia