kgo: add MaxBufferedBytes, Buffered{Fetch,Produce}Bytes #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twmb
force-pushed
the
544
branch
6 times, most recently
from
649d641 to
554974a
Compare
twmb
changed the title
Closes #544.
This slows down fetching a little bit. If it is egregious, we can fix the perf by tracking the size buffered when processing the fetch itself, and then adding a new field to batch-untrack the size. That's left as an exercise for a person that cares. This is now done since the prior commit introduces buffered produce bytes, and we may as well add it while fetching for both-sizes consistency, and we may as well expose it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #544.