Skip to content
This repository has been archived by the owner on Sep 18, 2021. It is now read-only.

DeliveryReceipt, err:null error #89

Open
khaing211 opened this issue Apr 16, 2015 · 2 comments
Open

DeliveryReceipt, err:null error #89

khaing211 opened this issue Apr 16, 2015 · 2 comments

Comments

@khaing211
Copy link
Contributor

when DeliveryReceipt is initialized by constructor

 public DeliveryReceipt(String messageId, int submitCount, int deliveredCount, DateTime submitDate, DateTime doneDate, byte state, int errorCode, String text)

, rawErrorCode is not set. As a result, when toShortMessage() is called, it yield incorrect "err:null" field
@khaing211 khaing211 changed the title when DeliveryReceipt is initialized by constructor public DeliveryReceipt(String messageId, int submitCount, int deliveredCount, DateTime submitDate, DateTime doneDate, byte state, int errorCode, String text), rawErrorCode is not set DeliveryReceipt, err:null error Apr 16, 2015
@jjlauer
Copy link
Contributor

jjlauer commented Apr 16, 2015

Looks like a nice find. Would you be willing to take a stab at a fix and submit a PR?

@khaing211
Copy link
Contributor Author

Done.

jjlauer added a commit that referenced this issue Apr 17, 2015
@jjlauer
Merge pull request #90 from khaing211/master
bb9f370 
#89 DeliveryReceipt, err:null error
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jjlauer @khaing211