Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeline feature #647

Open
trusktr opened this issue Apr 23, 2023 · 1 comment
Open

Timeline feature #647

trusktr opened this issue Apr 23, 2023 · 1 comment
Labels

Comments

@trusktr
Copy link
Member

trusktr commented Apr 23, 2023

The Tween class is doing a lot. Maybe it is starting to grow out of scope for what a Tween is. For example, we can chain, yoyo, repeat tweens, etc. Maybe it would be better to have a cleaner separation of concerns and introduce a new Timeline class (maybe convert Group with Timeline) that would be generally more robust for this.

What could this Timeline API looks like? How would Tween play with Timeline? Perhaps Tweens are added to Timelines.

This comment has some ideas: #560 (comment)

Food for thought:

const track1 = new Sequence([
  new Empty(300),
  new Tween(mesh.rotation).to(..., 1000),
  new Tween(mesh.position).delay(500).to(..., 1000),
])

const track2 = new Tween(otherThing).to(2000)

const timeline = new Timeline([ // parallel
  // tracks for the timeline
  track1,
  track2
])

const anim = new Animation([timeline]).start() // start/stop/repeat/etc similar to current Tween perhaps

requestAnimationFrame(function loop() {
  anim.update()
  requestAnimationFrame(loop)
})

const timeline2 = new Timeline([
  timeline, // this timeline
  new Tween(...).to(...), // will play in parallel to this tween
])

const anim2 = new Animation([timeline2])

// etc
@cuixiping
Copy link

Group and .chain() can be enhanced to cover the cases.
Group should have all methods of tween instance.
.chain() should can be chained more times.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants