Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional changes after bzlmod separation #200

Merged
merged 2 commits into from
Mar 16, 2022
Merged

Additional changes after bzlmod separation #200

merged 2 commits into from
Mar 16, 2022

Conversation

avdv
Copy link
Member

@avdv avdv commented Mar 16, 2022

This PR rounds out the changes in #193:

  • add BUILD.pkg file back
  • handle strip_prefix of git_repository and http_archive when adding the sub-modules

avdv added 2 commits March 16, 2022 08:39
@avdv
Re-add nixpkgs/BUILD.pkg for backwards compatibility
eaac977 
This file was moved into the core module, but there might be users out there assuming
this file exists at the old place.
@avdv
Take the existing strip_prefix into account
93d972a
aherrmann
aherrmann approved these changes Mar 16, 2022
View reviewed changes
Copy link
Member

@aherrmann aherrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you!

@mergify mergify bot merged commit 4a2efda into master Mar 16, 2022
@mergify mergify bot deleted the issue-182-aux branch March 16, 2022 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aherrmann aherrmann aherrmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@avdv @aherrmann