Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Faulty enum comparison #308

Closed
ValentinFutterer opened this issue Dec 17, 2024 · 0 comments · Fixed by #314
Closed

Faulty enum comparison #308

ValentinFutterer opened this issue Dec 17, 2024 · 0 comments · Fixed by #314
Labels
bug Something isn't working

Comments

@ValentinFutterer
Copy link
Collaborator

ValentinFutterer commented Dec 17, 2024 •
edited
Loading

Describe the bug
In AbstractTemplateExportScienceEuropeComponents, enums are compared using toString. They should be compared with a null safe Objects.equal though. This error causes the coordinator export to not export the id.

image

Also try to find other instances of this wrong comparison, if they still occur.

Is this a regression?
Yes.

Expected behavior
Correct comparison should be done, fixing the bug.

Environment

  • Damap version 4.3.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Export: Use Objects.equals to perform a null-safe enum check tuwien-csd/damap-backend
2 participants
@GeoffreyKarnbach @ValentinFutterer