Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run the iOS Tests in the Swift CI workflow #7314

Closed
rezbyte opened this issue Jul 30, 2024 · 2 comments
Closed

Run the iOS Tests in the Swift CI workflow #7314

rezbyte opened this issue Jul 30, 2024 · 2 comments
Labels
improvement nice-to-haves that are not impeding usage of any features maintenance dependency updates, key renewals, code cleanup
Milestone
Technical tasks

Comments

@rezbyte
Copy link
Contributor

rezbyte commented Jul 30, 2024

The Swift CI GitHub Action workflow (.github/workflows/swift-test.yml) should also run the tests under app-ios/tutanotaTests and https://github.com/tutao/tutanota/tree/master/app-ios/TutanotaSharedTests. That way, we can be sure these tests pass on any given PR without manually running them.
@rezbyte rezbyte added improvement nice-to-haves that are not impeding usage of any features maintenance dependency updates, key renewals, code cleanup labels Jul 30, 2024
@rezbyte rezbyte added this to the Technical tasks milestone Jul 30, 2024
@charlag
Copy link
Contributor

charlag commented Jul 30, 2024

I think this was done as part of #7285

@rezbyte
Copy link
Contributor Author

rezbyte commented Jul 31, 2024

I think this was done as part of #7285

Ah, it seems so. I will close this issue then.

@rezbyte rezbyte closed this as not planned Won't fix, can't repro, duplicate, stale Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement nice-to-haves that are not impeding usage of any features maintenance dependency updates, key renewals, code cleanup
Projects
None yet
Milestone
Technical tasks
Development

No branches or pull requests
2 participants
@charlag @rezbyte