-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(db/create): ask to wake sleeping groups before create #900
Closed
Closed
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
c160c2b
feat(db/create): ask to wake sleeping groups before create
notrab d57d29c
create group utils
notrab 2041cf5
check group is unarchived before connecting to shell
notrab 98a4981
remove 💤 emoji
notrab a4ce8a8
use promptConfirmation
notrab dc8aa23
dont print success twice
notrab 77bbb44
retry based on error
notrab File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
package cmd | ||
|
||
import ( | ||
"fmt" | ||
"strings" | ||
|
||
"github.com/tursodatabase/turso-cli/internal" | ||
"github.com/tursodatabase/turso-cli/internal/turso" | ||
) | ||
|
||
func ensureGroupAwake(client *turso.Client, groupName string) (bool, error) { | ||
group, err := getGroup(client, groupName) | ||
if err != nil { | ||
return false, fmt.Errorf("failed to get group info: %w", err) | ||
} | ||
|
||
groupStatus := aggregateGroupStatus(group) | ||
if groupStatus != "Archived 💤" { | ||
notrab marked this conversation as resolved.
Show resolved
Hide resolved
|
||
return true, nil | ||
} | ||
|
||
fmt.Printf("The group %s is currently archived. Do you want to wake it up? [Y/n]: ", internal.Emph(groupName)) | ||
notrab marked this conversation as resolved.
Show resolved
Hide resolved
|
||
var response string | ||
fmt.Scanln(&response) | ||
response = strings.ToLower(strings.TrimSpace(response)) | ||
if response == "" || response == "y" || response == "yes" { | ||
err = unarchiveGroup(client, groupName) | ||
if err != nil { | ||
return false, fmt.Errorf("failed to wake up group: %w", err) | ||
} | ||
fmt.Printf("Group %s has been woken up.\n", internal.Emph(groupName)) | ||
return true, nil | ||
} | ||
|
||
return false, nil | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a fan of this approach because:
The "better" way would be to be able to detect archived errors from API responses and handle those properly.
Not a blocker though, feel free to move forward if you don't have the time to address this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree this would be better.