Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent reporting HttpDispatch errors in sync_offline #1923

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

levydsa
Copy link
Contributor

@levydsa levydsa commented Jan 17, 2025

Resolves #1919

This PR also includes a internal API change regarding, it is straight forward enough to be included in the same PR.

@levydsa levydsa requested a review from penberg January 17, 2025 03:48
@levydsa levydsa changed the title Prevent reporting http errors in sync_offline Prevent reporting HttpDispatch errors in sync_offline Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make sync() safe to be called even offline
1 participant