Do not add connections in error to plugin manager connection map. Closes

 #3893

cmd/plugin_manager.go

@@ -93,6 +93,7 @@ func createPluginManager(cmd *cobra.Command) (*pluginmanager_service.PluginManag
 		}
 	}()
 
+	// create a map of connections configs, excluding connections in error
 	configMap := connection.NewConnectionConfigMap(steampipeConfig.Connections)
 	log.Printf("[TRACE] loaded config map: %s", strings.Join(steampipeConfig.ConnectionNames(), ","))
 

pkg/connection/config_map.go

@@ -8,9 +8,15 @@ import (
 
 type ConnectionConfigMap map[string]*sdkproto.ConnectionConfig
 
+// NewConnectionConfigMap creates a map of sdkproto.ConnectionConfig keyed by connection name
+// NOTE: connections in error are EXCLUDED
 func NewConnectionConfigMap(connectionMap map[string]*modconfig.Connection) ConnectionConfigMap {
 	configMap := make(ConnectionConfigMap)
 	for k, v := range connectionMap {
+		if v.Error != nil {
+			continue
+		}
+
 		configMap[k] = &sdkproto.ConnectionConfig{
 			Connection:       v.Name,
 			Plugin:           v.Plugin,

pkg/pluginmanager_service/plugin_manager.go

@@ -442,7 +442,7 @@ func (m *PluginManager) addRunningPlugin(pluginInstance string) (*runningPlugin,
 	pluginConfig := m.plugins[pluginInstance]
 	if pluginConfig == nil {
 		// not expected
-		return nil, sperr.New("plugin manager has no config for plkugin instance %s", pluginInstance)
+		return nil, sperr.New("plugin manager has no config for plugin instance %s", pluginInstance)
 	}
 	// create the running plugin
 	startingPlugin := &runningPlugin{

pkg/pluginmanager_service/plugin_manager_rate_limiters.go

@@ -211,7 +211,7 @@ func (m *PluginManager) initialiseRateLimiterDefs(ctx context.Context) (e error)
 	if err != nil {
 		return err
 	}
-	// TODO KAI TACTICAL to force recreation
+	// TODO KAI TACTICAL to force recreation - remove in beta.2
 	rateLimiterTableExists = false
 
 	if !rateLimiterTableExists {